Fix reloading in Ruby 3.3 #730
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures the application is restarted when a preloaded file is changed. This has been silently broken because the fallback behavior still results in the application being restarted, but only when the user next runs a command—hence the acceptance test still passing. The behavior of `BasicSocket#recv` changed in Ruby 3.3 [1] such that it now returns `nil` on a closed stream socket, instead of an empty string. When we call `#empty?` on `nil` the `NoMethodError` is swallowed by the failsafe thread and the application is not restarted. This commit fixes the issue by checking both `#nil?` and `#empty?` so it works with both old and new versions. It also updates the acceptance test to be more specific about what it considers a "reload" by asserting the relevant log line exists. [1]: ruby/ruby#6407
|
These logs were produced with a Rails app using Ruby 3.3.5.
Before After |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures the application is restarted when a preloaded file is changed. This has been silently broken because the fallback behavior still results in the application being restarted, but only when the user next runs a command—hence the acceptance test still passing.
The behavior of
BasicSocket#recvchanged in Ruby 3.3 such that it now returnsnilon a closed stream socket, instead of an empty string. When we call#empty?onniltheNoMethodErroris swallowed by the failsafe thread and the application is not restarted.This commit fixes the issue by checking both
#nil?and#empty?so it works with both old and new versions. It also updates the acceptance test to be more specific about what it considers a "reload" by asserting the relevant log line exists.