Added support for /V range search logic #23426
Merged
+48
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trufae
reviewed
Oct 5, 2024
libr/main/rafind2.c
Outdated
|
|
||
| if (comma) { | ||
| *comma++ = 0; | ||
| min_value = r_num_math(NULL, colon); |
There was a problem hiding this comment.
Use the proper indentation rules. Spaces before (, dont define variables in the for() block..
There was a problem hiding this comment.
@trufae I’ve made the requested changes, including updating the help message and ensuring proper indentation/styling. Please let me know if there’s anything else you’d like me to adjust.
There was a problem hiding this comment.
Perfect :) merged! Its always good to have some tests but not mandarory. Thank you for your first contribution!
|
Can you update the manpage and help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for the
Vflag in therafind2command, enabling value-range searches as specified in issue #22704. Users can now specify a range of values using the format/V<size>:<min_value>[,<max_value>], which enhances data manipulation capabilities. The implementation includes input parsing and size validation.Please review my implementation and provide feedback.