Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Classic Queue version to operator policies #9541

Closed
wants to merge 1 commit into from
Closed

Add Classic Queue version to operator policies #9541

wants to merge 1 commit into from

Conversation

SignalWhisperer
Copy link
Contributor

@SignalWhisperer SignalWhisperer commented Sep 26, 2023

Proposed Changes

As part of migrating to having Classic Queues version 2 by default in 3.13, the recommended way to migrate is to set a policy for queue-version: 2. As an operator, it can be difficult to have users set the policy on all of their queues. If an operator were to add a policy to set the queue version, any user setting their own higher priority custom policy but not setting the queue version would revert it back to the configured default.

This adds the Classic Queue version to operator policies, overriding the policy set by the user in favour of that set by the operator. This will allow for a smoother transition, but also will let operators decide of the underlying queue version regardless of the compliance of the users.

Types of Changes

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

@SignalWhisperer SignalWhisperer marked this pull request as ready for review September 26, 2023 21:08
@michaelklishin
Copy link
Member

@SignalWhisperer sorry, can you please rebase?

@michaelklishin
Copy link
Member

No need, it did not take much time or context to resolve.

@michaelklishin
Copy link
Member

Merged as part of #9547.

michaelklishin added a commit that referenced this pull request Sep 27, 2023
it was named by copying and pasting an adjacent
one that indeed had to do with queue type-specific
policies but "version-specific" policies is not
something RabbitMQ supports

References #9547 #9541
michaelklishin added a commit that referenced this pull request Sep 27, 2023
it was named by copying and pasting an adjacent
one that indeed had to do with queue type-specific
policies but "version-specific" policies is not
something RabbitMQ supports

References #9547 #9541

(cherry picked from commit e63b6a6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants