Usability impovements #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@r3stl355 Hi there, would you please check out this PR? It would be great not to fork development and I'm more than happy to contribute. Thanks |
|
Hey @adalpane, thank you for the PR, I will review in the next few days (was not around for the past couple of weeks). In the meantime, can you please make sure that the checks pass? Thanks |
|
I have fixed the format and tests are passing locally |
|
Apologies again for the delay @adalpane, it will be done this weekend, finally I have some time |
|
All done, thank you |
|
hi again @r3stl355, do you think you can bump up major version to reach 0.2.0 and make a release on crates.io to include this work? |
|
Sure, why not. Will do this weekend |
|
Hey @adalpane , all done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello and thank you for your work on delta-sharing-rust-client
I have come to use it myself and it turns out that I required some improvements:
The library should never panic, otherwise requires the caller to catch unwind which is pretty tedious in async context and must not be considered real error handling anyways
The library should allow to specify on
get_dataframethe same parameters thatlist_table_files, since right now it is defaulting them to NoneThe client must be able to pass the
delta-sharing-capabilitiesheader on each callThe Delta format (aside of Parquet format) must be supported as specified in protocol
Please review my PR and if you think it's worth to be merged I'll be happy to contribute.