Let use_package() decrement a package dependency.
#2043
Conversation
R/helpers.R
Outdated
| direction <- ifelse(version_spec(version) > version_spec(existing_version), | ||
| "Increasing", "Decreasing") |
There was a problem hiding this comment.
Can you change this to an if () ... else? I generally reserve ifelse() for vectorized situations.
R/helpers.R
Outdated
| "Increasing", "Decreasing") | ||
|
|
||
| ui_bullets(c( | ||
| "v" = "{.drn {direction}} {.pkg {package}} version to {.val {version}} in |
There was a problem hiding this comment.
I'm not familiar with the .drn inline markup. Can you help me understand that?
There was a problem hiding this comment.
I just tried to replicate the same logic as in {.pkg {package}} and{.val {version}}. I tried to remove .drn and then {direction} would not resolve with the string in the object direction. Any hint?
There was a problem hiding this comment.
Something like {.pkg {package}} does interpolation of package through its surrounding brackets. Then .pkg and the second layer of brackets applies some inline styling.
For pure interpolation (which is the goal with direction), we just need one pair of brackets.
You can learn more about this in the cli package: https://cli.r-lib.org/reference/inline-markup.html.
There was a problem hiding this comment.
Thanks for pointing this out, and thanks again for your time and patience today!
Fixes #1957.