Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update broken links and add cython to environment.yml #50

Merged
merged 10 commits into from
Nov 18, 2022

Conversation

hodgestar
Copy link
Contributor

@hodgestar hodgestar commented Nov 7, 2022

Minor fixes:

  • Update the nbviewer links to use nbviewer.jupyter.org (nbviewer.ipython.org is deprecated and no longer works).
  • Update the dead quantum teleportation reference with the Wikipedia article.
  • Add Cython to the environment.yml, which is slightly friendlier to developers who might expect Cython to be installed when editing tutorials (see Add cython to environment.yml. #46).

@hodgestar hodgestar changed the title Add Cython to environment.yml. Update nbviewer links and add Cython to environment.yml. Nov 7, 2022
@hodgestar hodgestar changed the title Update nbviewer links and add Cython to environment.yml. Update broken links and add cython to environment.yml Nov 7, 2022
@hodgestar
Copy link
Contributor Author

@christian512 There are three strange failures in this PR that are unrelated to the PR itself. Any chance you could take a look?

@christian512
Copy link
Collaborator

After a re-run of the jobs, it looks like there is only a problem with pdflatex. The CI installs the package texlive-latex-extra. This also includes the installation of texlive-picture, which contains the required qcircuit package.

I am not sure if there were recent changes in qutip-qip that broke this plotting function. @BoxiLi, do you have an idea?

@BoxiLi
Copy link
Member

BoxiLi commented Nov 8, 2022

Okay, I'll have a look. Let me try testing pdflatex directly in the command line on the GitHub action machine.

@christian512
Copy link
Collaborator

I ran pdflatex manually in a GitHub action in this job: https://github.com/christian512/qutip-tutorials/actions/runs/3426603357/jobs/5708606925

There is an error with Xy-pic, which I don't understand. Maybe you can take a look.

@BoxiLi
Copy link
Member

BoxiLi commented Nov 9, 2022

Okay, I tried it locally. The generated tex code is wrong (should have checked it earlier...). This seems to be related to qutip/qutip-qip#166.

@BoxiLi
Copy link
Member

BoxiLi commented Nov 9, 2022

I pushed a fix on qutip/qutip-qip#177

@BoxiLi
Copy link
Member

BoxiLi commented Nov 9, 2022

Seems the circuit plotting error is gone now but there are a few others.

Copy link
Contributor Author

@hodgestar hodgestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 -- thanks @christian512 for fixing all the little bugs that crept in. We should add the nightly build so that these don't sneak in so easily in future.

@hodgestar hodgestar merged commit e60f4f1 into main Nov 18, 2022
@hodgestar hodgestar deleted the feature/add-cython-to-environment-yaml branch November 21, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants