Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RZX gate to the SCQubits model #245

Merged
merged 9 commits into from
Aug 29, 2024
Merged

Add RZX gate to the SCQubits model #245

merged 9 commits into from
Aug 29, 2024

Conversation

BoxiLi
Copy link
Member

@BoxiLi BoxiLi commented Aug 14, 2024

  • Add the RZX gate for the SCQubits. It was the building block for CNOT but is now separated to generate Hamiltonian simulation more conveniently.
  • Fix a bug in the gate decomposition, if the gate is added as a native gate, the resolve function lets it pass without an error.
  • Fix a bug in the compilation of the ZX Hamiltonian. The wrong hardware parameters were used for the compilation (mismatch in the qubit label.

@hodgestar
Copy link
Contributor

It looks like quite a few small details changed here. Could you add tests?

@BoxiLi
Copy link
Member Author

BoxiLi commented Aug 14, 2024

Yes! The test is on the way. This is for the example in the qutip paper ;)

@BoxiLi BoxiLi added this to the qutip-qip-0.3.2 milestone Aug 22, 2024
Copy link
Contributor

@hodgestar hodgestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests. Looks good. I left some questions.

src/qutip_qip/circuit/circuit.py Show resolved Hide resolved
src/qutip_qip/compiler/circuitqedcompiler.py Outdated Show resolved Hide resolved
src/qutip_qip/compiler/circuitqedcompiler.py Outdated Show resolved Hide resolved
Copy link
Contributor

@hodgestar hodgestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see there is still a doctest error, but otherwise the changes look good to me.

@BoxiLi BoxiLi merged commit 7633f6e into qutip:master Aug 29, 2024
12 of 13 checks passed
@BoxiLi BoxiLi deleted the paper_sim branch August 29, 2024 11:59
BoxiLi added a commit to BoxiLi/qutip-qip that referenced this pull request Sep 1, 2024
- Add the RZX gate for the SCQubits. It was the building block for CNOT but is now separated to generate Hamiltonian simulation more conveniently.
- Fix a bug in the gate decomposition, if the gate is added as a native gate, the resolve function lets it pass without an error.
- Fix a bug in the compilation of the ZX Hamiltonian. The wrong hardware parameters were used for the compilation (mismatch in the qubit label.
BoxiLi added a commit to BoxiLi/qutip-qip that referenced this pull request Sep 1, 2024
- Add the RZX gate for the SCQubits. It was the building block for CNOT but is now separated to generate Hamiltonian simulation more conveniently.
- Fix a bug in the gate decomposition, if the gate is added as a native gate, the resolve function lets it pass without an error.
- Fix a bug in the compilation of the ZX Hamiltonian. The wrong hardware parameters were used for the compilation (mismatch in the qubit label.
BoxiLi added a commit that referenced this pull request Sep 4, 2024
# Version 0.3.2

Improvements
------------
- Add RZX gate to the SCQubits model. Fix bugs on the ZX strength. (#245)
- Compile the documentation using qutip v5 (#246)

Bug Fixes
---------
- Add phi parameter to expand_operator call. (#237, issue raised by Neill Lambert)
- Fix the warning on MacOS. (#240)
- Fix a bug in :class:`~.QubitCircuit.add_1q_gate`. (#250, issue raised by hatlabcz Chao Zhou)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants