Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a minus sign for plotting the swap gate #170

Merged
merged 3 commits into from
Sep 16, 2022
Merged

Add a minus sign for plotting the swap gate #170

merged 3 commits into from
Sep 16, 2022

Conversation

BoxiLi
Copy link
Member

@BoxiLi BoxiLi commented Sep 11, 2022

Fix #166

@BoxiLi BoxiLi added this to the qutip-qip-0.2.3 milestone Sep 11, 2022
hodgestar
hodgestar approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@hodgestar hodgestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Climate has a complaint, but this look good to me.

@BoxiLi BoxiLi merged commit bf3f7c1 into qutip:master Sep 16, 2022
BoxiLi added a commit to BoxiLi/qutip-qip that referenced this pull request Oct 23, 2022
@BoxiLi
Merge pull request qutip#170 from BoxiLi/plotting_swap
48f9b51 
- Add a minus sign for plotting the swap gate

- Add a border so that SWAP gates are not cropped.

- Remove the unnecessary redefinition of qswap
@BoxiLi BoxiLi mentioned this pull request Nov 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hodgestar hodgestar hodgestar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
qutip-qip-0.2.3
Development

Successfully merging this pull request may close these issues.

Swap gates are incorrectly rendered in LaTeX
2 participants
@BoxiLi @hodgestar