Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight glitch Surah As-Saff (page 552: last ayah) #538

Closed
khalid-hussain opened this issue Jun 9, 2015 · 5 comments
Closed

Highlight glitch Surah As-Saff (page 552: last ayah) #538

khalid-hussain opened this issue Jun 9, 2015 · 5 comments

Comments

@khalid-hussain
Copy link

Assalamuʻalaikum,

I've tried editing the page image to remove that thin line on the bottom left but the highlight still comes up wrong. I don't think it has to do with the page image but with the database. This is not to say the page image should not be improved.

Screenshot:
@ATouhou
Copy link

ATouhou commented Jun 9, 2015

Bug confirmed on My Phone using the 1260 width.
It need to be fixed from ayah_1260.db i think mohammed :D
Den 09/06/2015 16.51 skrev "Mohammad Khalid Hussain" <
notifications@github.com>:

Assalamuʻalaikum,

I've tried editing the page image to remove that thin line on the bottom
left but the highlight still comes up wrong. I don't think it has to do
with the page image but with the database. This is not to say the page
image should not be improved.

Screenshot:

https://camo.githubusercontent.com/52cceb5c3c848f922785f7ce2f0dcf2ed9035f86/687474703a2f2f7332352e706f7374696d672e6f72672f6d66357a7a666e6b662f53637265656e73686f745f323031355f30365f30395f30375f34375f33302e706e67

—
Reply to this email directly or view it on GitHub
#538.

@khalid-hussain
Copy link
Author

The same issue occurs on the first page of Surah Al-Munafiqoon. I think it has to do with that really small dot on the bottom left of the image but I'm not sure.

Screenshot:

@ahmedre
Copy link
Contributor

ahmedre commented Jul 2, 2016

this is a bug with the font - we should fix this insha'Allah in the next version along with #663

@ahmedre
Copy link
Contributor

ahmedre commented Jul 2, 2016

depends on:
quran/quran.com-images#7
quran/quran.com-images#8

ahmedre added a commit that referenced this issue Jul 4, 2016
@ahmedre
Update patch set to 5.
ce6b40d 
This patch set fixes a few issues in highlighting and with some rogue
pixel noise. Specifically, it fixes the highlighting of 2:6, 61:14, and
63:4 (fixes #489 and #538). It also fixes some extra pixels that made
one dot look like one and a half donts (fixes #663). Finally, it added
some space between the last two verses of 12:17 (fixes #664).
@ahmedre
Copy link
Contributor

ahmedre commented Jul 4, 2016

fixed in ce6b40d

@ahmedre ahmedre closed this as completed Jul 4, 2016
ahmedre added a commit that referenced this issue Oct 14, 2017
@ahmedre
Update patch set to 5.
1a3c0c1 
This patch set fixes a few issues in highlighting and with some rogue
pixel noise. Specifically, it fixes the highlighting of 2:6, 61:14, and
63:4 (fixes #489 and #538). It also fixes some extra pixels that made
one dot look like one and a half donts (fixes #663). Finally, it added
some space between the last two verses of 12:17 (fixes #664).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ahmedre @khalid-hussain @ATouhou