-
Notifications
You must be signed in to change notification settings - Fork 361
add site association for ios universal linking #851
Conversation
@mohamede1945 to provide me with the appID |
should we support staging.quran.com subdomain ? might be the quickest way to test this. |
Deployed to: http://staging.quran.com:32927 |
@@ -55,6 +56,14 @@ export default (server) => { | |||
proxyOneQuran.web(req, res); | |||
}); | |||
|
|||
server.use('/apple-app-site-association', (req, res) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a static file(same as manifest.json), why we need route for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we set the content-type from the static folder? the file cannot have an extension of .json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to say you can use express' static file helper with the route and add content type. Not certain but this works
Deployed to: http://staging.quran.com:32928 |
@@ -55,6 +56,14 @@ export default (server) => { | |||
proxyOneQuran.web(req, res); | |||
}); | |||
|
|||
server.use('/apple-app-site-association', (req, res) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to say you can use express' static file helper with the route and add content type. Not certain but this works
"apps": [], | ||
"details": [ | ||
{ | ||
"appID": "abc.com.quran", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
? that's actually it? abc
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a place holder text, I was waiting for @mohamede1945
You can use |
@mmahalwy let's merge this in this way to ensure it works, then I am happy to give this another try with static folder approach. @mohamede1945 can we support, https://quran.com/ and https://staging.quran.com/ |
21049cc
to
29583e0
Compare
rebuild |
1 similar comment
rebuild |
Deployed to: http://staging.quran.com:32930 |
associated with quran/quran-ios#195