Skip to content
This repository has been archived by the owner on Jun 28, 2021. It is now read-only.

add site association for ios universal linking #851

Merged
merged 3 commits into from
Aug 7, 2017

Conversation

thabti
Copy link
Contributor

@thabti thabti commented Jul 30, 2017

associated with quran/quran-ios#195

  1. promoting the App
  2. Linking between our apps (quranicaudio is coming soon(TM)

@thabti thabti changed the title add site association for ios universal linking (wip) add site association for ios universal linking Jul 30, 2017
@thabti
Copy link
Contributor Author

thabti commented Jul 30, 2017

@mohamede1945 to provide me with the appID

@thabti
Copy link
Contributor Author

thabti commented Jul 30, 2017

should we support staging.quran.com subdomain ? might be the quickest way to test this.

@ahmedre
Copy link
Contributor

ahmedre commented Jul 30, 2017

Deployed to: http://staging.quran.com:32927

@@ -55,6 +56,14 @@ export default (server) => {
proxyOneQuran.web(req, res);
});

server.use('/apple-app-site-association', (req, res) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a static file(same as manifest.json), why we need route for this?

https://quran.com/manifest.json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we set the content-type from the static folder? the file cannot have an extension of .json

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to say you can use express' static file helper with the route and add content type. Not certain but this works

@ahmedre
Copy link
Contributor

ahmedre commented Jul 30, 2017

Deployed to: http://staging.quran.com:32928

@@ -55,6 +56,14 @@ export default (server) => {
proxyOneQuran.web(req, res);
});

server.use('/apple-app-site-association', (req, res) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to say you can use express' static file helper with the route and add content type. Not certain but this works

"apps": [],
"details": [
{
"appID": "abc.com.quran",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

? that's actually it? abc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a place holder text, I was waiting for @mohamede1945

@mohamede1945
Copy link

You can use MKP73M5X4A.com.quran.ios as appId.

@thabti thabti changed the title (wip) add site association for ios universal linking add site association for ios universal linking Aug 7, 2017
@thabti
Copy link
Contributor Author

thabti commented Aug 7, 2017

@mmahalwy let's merge this in this way to ensure it works, then I am happy to give this another try with static folder approach.

@mohamede1945 can we support, https://quran.com/ and https://staging.quran.com/

@thabti
Copy link
Contributor Author

thabti commented Aug 7, 2017

rebuild

1 similar comment
@thabti
Copy link
Contributor Author

thabti commented Aug 7, 2017

rebuild

@ahmedre
Copy link
Contributor

ahmedre commented Aug 7, 2017

Deployed to: http://staging.quran.com:32930

@thabti thabti merged commit 28a4557 into master Aug 7, 2017
@thabti thabti deleted the feature/siteAssociation branch August 7, 2017 14:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants