-
Notifications
You must be signed in to change notification settings - Fork 361
closes #398 - "Previous/Next Surah" when reading first/last surah #412
Conversation
Deployed to: http://staging.quran.com:32831 |
@@ -0,0 +1,62 @@ | |||
import React from 'react'; | |||
import ReactDOM from 'react-dom'; | |||
import { shallow, render } from 'enzyme'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i dont think you are using render
woot! This is awesome mashallah :) |
fixes have been pushed. |
Deployed to: http://staging.quran.com:32832 |
@@ -3,11 +3,11 @@ | |||
"version": "1.0.0", | |||
"private": false, | |||
"scripts": { | |||
"test": "./node_modules/karma/bin/karma start", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just an FYI, npm makes anything within node_modules/.bin usable as a global within npm scripts.
Deployed to: http://staging.quran.com:32839 |
can we get this merged in? |
Deployed to: http://staging.quran.com:32840 |
Deployed to: http://staging.quran.com:32842 |
merged based on your previous comment @mmahalwy |
Why this doesn't show in quran.com ? |
@srifqi I don't think there was a production release. https://github.com/quran/quran.com-frontend/commits/production |
Fixed + unit tests
closes #398