made the verse actions popup close automatically after the user starts playing a verse #2126
+59
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@0XYoussefX0 is attempting to deploy a commit to the Quran Team on Vercel. A member of the Team first needs to authorize it. |
0XYoussefX0
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@osamasayed can you please review my PR? |
Alsalmau Alikum brother, Jazak Allahu Khairan for your contribution. Before I am able to review it please make sure it can build successfully as currently it's not working. You can try to run "yarn build" locally first. |
|
@osamasayed done 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
when the user opens the modal to repeat a verse and clicks the start playing button, the modal stays open, This PR fixes that.
this fix was already requested by users in here
Screenshots