Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raidboss: Support for objects in trigger outputStrings #5861

Merged
merged 21 commits into from
Nov 2, 2023
Merged

raidboss: Support for objects in trigger outputStrings #5861

merged 21 commits into from
Nov 2, 2023

Commits on Aug 7, 2023

  1. Preliminary support for objects in trigger outputStrings

    @valarnin
    valarnin committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    2a6c8c9 View commit details
    Browse the repository at this point in the history

  2. Limit param keys to only top-level props 

    Extract the ShortName logic/functions to Util, clean up duplicate code
Narrow the typedef for params objects
Add helpers to get party member param object
Add config option for default display label for players
Clean up handling of param objects
    @valarnin
    valarnin committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    314ec15 View commit details
    Browse the repository at this point in the history

  3. Fix missing changes, thanks WSL

    @valarnin
    valarnin committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    13f5c5f View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Adrienne Walker <enne@quisquo.us>
    @valarnin @quisquous
    valarnin and quisquous committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    9b93f2f View commit details
    Browse the repository at this point in the history

  5. Cleanup per review, fix issue with suggestion

    @valarnin
    valarnin committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    6ad450f View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. Rebase to upstream/main

    @valarnin
    valarnin committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    1a299af View commit details
    Browse the repository at this point in the history

  2. Default paramObjectFromName return object to something sane

    @valarnin
    valarnin committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    917e08d View commit details
    Browse the repository at this point in the history

  3. Fix test errors

    @valarnin
    valarnin committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    84b8d34 View commit details
    Browse the repository at this point in the history

  4. Fix other test/lint errors

    @valarnin
    valarnin committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    f289df5 View commit details
    Browse the repository at this point in the history

  5. Change type on role

    @valarnin
    valarnin committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    2ad88a5 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2023

  1. Merge branch 'main' into valarnin-outputstrings-objects

    @quisquous
    quisquous committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    0cffdbf View commit details
    Browse the repository at this point in the history

  2. simplify calls to shortName

    @quisquous
    quisquous committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    bebdf39 View commit details
    Browse the repository at this point in the history

  3. handle missing/default parameters

    @quisquous
    quisquous committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    e9fcc96 View commit details
    Browse the repository at this point in the history

  4. rename shortName field to nick

    @quisquous
    quisquous committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    69ded7e View commit details
    Browse the repository at this point in the history

  5. make some party obj fields optional for better fallback

    @quisquous
    quisquous committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    5121b99 View commit details
    Browse the repository at this point in the history

  6. move to using data.party.member

    @quisquous
    quisquous committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    c77169a View commit details
    Browse the repository at this point in the history

  7. more manual testing output

    @quisquous
    quisquous committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    6d0e7a1 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2023

  1. review comments

    @quisquous
    quisquous committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    078cb5b View commit details
    Browse the repository at this point in the history

  2. remove config option until triggersets converted

    @quisquous
    quisquous committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    3ec9c12 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. explicit PartyTrackerOptions

    @quisquous
    quisquous committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    baadb21 View commit details
    Browse the repository at this point in the history

  2. remember to add file too

    @quisquous
    quisquous committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    25a6ffb View commit details
    Browse the repository at this point in the history