Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raidboss: timeline & initial triggers for Golbez (normal) #5534

Merged
merged 3 commits into from
Jun 10, 2023
Merged

raidboss: timeline & initial triggers for Golbez (normal) #5534

merged 3 commits into from
Jun 10, 2023

Conversation

wexxlee
Copy link
Contributor

@wexxlee wexxlee commented Jun 9, 2023

Tested in raidemulator and a couple of pulls in-game.
Per my comment in #5405 I'll do another PR tomorrow with some basic oopsy stuff as well.

Edit: Closes #5497

Copy link
Owner

@quisquous quisquous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! I really appreciate filling in missing content.

Comment on lines 96 to 107
return output.clones!({
dir1: output[dir1]!() ?? '??',
dir2: output[dir2]!() ?? '??',
dir3: output[dir3]!() ?? '??',
dir4: output[dir4]!() ?? '??',
});
},
outputStrings: {
clones: {
en: 'Clones: ${dir1}->${dir2}->${dir3}->${dir4}',
},
...Directions.outputStringsCardinalDir,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return output.clones!({
dir1: output[dir1]!() ?? '??',
dir2: output[dir2]!() ?? '??',
dir3: output[dir3]!() ?? '??',
dir4: output[dir4]!() ?? '??',
});
},
outputStrings: {
clones: {
en: 'Clones: ${dir1}->${dir2}->${dir3}->${dir4}',
},
...Directions.outputStringsCardinalDir,
return output.clones!({
dir1: output[dir1]!() ?? output.unknown!(),
dir2: output[dir2]!() ?? output.unknown!(),
dir3: output[dir3]!() ?? output.unknown!(),
dir4: output[dir4]!() ?? output.unknown!(),
});
},
outputStrings: {
clones: {
en: 'Clones: ${dir1}->${dir2}->${dir3}->${dir4}',
},
unknown: Outputs.unknown,
...Directions.outputStringsCardinalDir,

In general I'd prefer not to have strings come from anywhere but the outputStrings section (even if it's just ???).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I'd prefer not to have strings come from anywhere but the outputStrings section (even if it's just ???).

Got it. The strange thing is that we shouldn't need to include unknown: Outputs.unknown in outputStrings, as Directions.outputStringsCardinalDir already contains an identical property. But if I omit it, eslint (specifically, rulesdir/cactbot-output-strings throws an error that 'unknown' is not a property in 'output'.

If we want to continue to spread direction-related (and potentially other/future) outputStrings in this manner, should I open an issue to update that lint rule? (I can take a look at it, but I'm not very familiar with lint.)

Comment on lines 61 to 63
234.3 "Void Stardust" sync / 1[56]:[^:]*:Golbez:84A3:/
238.2 "Void Stardust" sync / 1[56]:[^:]*:Golbez:84A5:/
248.5 "Void Meteor" sync / 1[56]:[^:]*:Golbez:84AC:/ duration 4
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 84A3 the telegraph, 84A5 the first hit, and 84AC the continuing damage? Or, what are these ids? Mostly wondering if this needs some extra text here or an ignored id. The extreme says (preview) on the telegraph, for what it's worth.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

84A3 is the initial (2.7 sec.) cast that shows the corner meteor marker. At the conclusion of the cast, the remaining telegraphs are shown. 84A5 is a longer cast, started at the same time as 84A3, that eventually corresponds to damage from that corner meteor exploding. 84A9 (ignored) is damage from the subsequent meteors.
(84AC is Void Meteor, which is a separate mechanic -- the dual tankbuster. Yeah, these names aren't confusing at all...)

I added (preview) on 84A3 and a small duration on 84A5 to correspond to the subsequent meteor hits. It's a slightly longer duration than the extreme, because that's how long the 84A9 abilities take to resolve, but it otherwise matches what we're doing there.

@github-actions github-actions bot added the oopsy label Jun 10, 2023
@quisquous quisquous merged commit 7231711 into quisquous:main Jun 10, 2023
github-actions bot pushed a commit that referenced this pull request Jun 10, 2023
…mal) (#5534)

Tested in raidemulator and a couple of pulls in-game.
Per my comment in #5405 I'll do another PR tomorrow with some basic
oopsy stuff as well.

Edit:  Closes #5497 7231711
github-actions bot pushed a commit that referenced this pull request Jun 10, 2023
…mal) (#5534)

Tested in raidemulator and a couple of pulls in-game.
Per my comment in #5405 I'll do another PR tomorrow with some basic
oopsy stuff as well.

Edit:  Closes #5497 7231711
@wexxlee wexxlee deleted the voidcast-dais branch June 15, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No Callouts For Normal Golbez Trial
2 participants