Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require slab 0.4.6 or higher #1970

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Require slab 0.4.6 or higher #1970

merged 1 commit into from
Aug 19, 2024

Conversation

finnbear
Copy link
Contributor

It's required for the vacant_key function to exist.

See

quinn/quinn-proto/src/endpoint.rs

Line 407 in 1e48a70

let ch = ConnectionHandle(self.connections.vacant_key());

See https://github.com/tokio-rs/slab/blob/f7b621f6cf2bc84f32214029b32d587d18277e3d/CHANGELOG.md?plain=1#L16-L18

@finnbear finnbear changed the title Require slab 0.4.6 Require slab 0.4.6 or higher Aug 19, 2024
djc
djc approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djc djc added this pull request to the merge queue Aug 19, 2024
Merged via the queue into quinn-rs:main with commit b9ce9c8 Aug 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@finnbear @djc