Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable use of aws-lc-rs instead of ring #1962

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Enable use of aws-lc-rs instead of ring #1962

wants to merge 3 commits into from

Conversation

djc
Copy link
Member

@djc djc commented Aug 8, 2024

Still needs a CI workflow to ensure that this actually works.

@djc djc requested a review from Ralith August 8, 2024 09:07
@djc djc force-pushed the aws-lc-rs branch 3 times, most recently from 79d62a0 to 267ccbb Compare August 8, 2024 09:14
@djc djc enabled auto-merge August 8, 2024 12:58
@djc djc disabled auto-merge August 8, 2024 12:58
quinn-proto/Cargo.toml Outdated Show resolved Hide resolved
quinn/Cargo.toml Outdated Show resolved Hide resolved
quinn-proto/src/cid_generator.rs Show resolved Hide resolved
@Ralith Ralith mentioned this pull request Aug 10, 2024
@Berrysoft
Copy link

Would you provide an option to disable both aws-lc-rs and ring? I would like to try another third-party adapter.

@djc
Copy link
Member Author

djc commented Sep 16, 2024

Would you provide an option to disable both aws-lc-rs and ring? I would like to try another third-party adapter.

This should already be the case both in released versions and once this PR is merged.

@djc djc force-pushed the aws-lc-rs branch 4 times, most recently from 4e808d4 to 424502f Compare September 16, 2024 09:58
@djc
Copy link
Member Author

djc commented Sep 16, 2024

Addressed comments and added CI job to test this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants