ci: add Android job #1950
Merged
ci: add Android job #1950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
commented
Aug 1, 2024
There was a problem hiding this comment.
This is ready for a first review.
I hoped to be able to reproduce #1947 with the x86 branch of this workflow. Thus far without success. I will debug further. In the meantime, I believe running Android tests is useful by itself.
Let me know what you think.
(I suggest I squash towards the end.)
Ralith
approved these changes
Aug 8, 2024
mxinden
commented
Aug 14, 2024
djc
approved these changes
Aug 19, 2024
mxinden
force-pushed
the
ci-android
branch
2 times, most recently
from
6dcaad0
to
7b74ffe
Compare
Haven't seen this happening before. I will look into it. |
mxinden
force-pushed
the
ci-android
branch
2 times, most recently
from
81f0683
to
898cba1
Compare
mxinden
added a commit
to mxinden/quinn
that referenced
this pull request
Aug 22, 2024
When extracting the emulator script into a separate file, the `matrix.target` substitution wasn't replaced with an environment variable. Follow-up to quinn-rs#1950.
mxinden
added a commit
to mxinden/quinn
that referenced
this pull request
Aug 23, 2024
When extracting the emulator script into a separate file, the `matrix.target` substitution wasn't replaced with an environment variable. Follow-up to quinn-rs#1950. Also the `ecn_*` unit tests are failing with any Android API version < v26 with: ``` 2024-08-22T14:41:30.636494Z WARN quinn_udp: sendmsg error: Os { code: 22, kind: InvalidInput, message: "Invalid argument" }, Transmit: { destination: 127.0.0.1:50196, src_ip: None, enc: Some(Ect0), len: 5, segment_size: None } ```
mxinden
added a commit
to mxinden/quinn
that referenced
this pull request
Aug 23, 2024
When extracting the emulator script into a separate file, the `matrix.target` substitution wasn't replaced with an environment variable. Follow-up to quinn-rs#1950.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 23, 2024
When extracting the emulator script into a separate file, the `matrix.target` substitution wasn't replaced with an environment variable. Follow-up to #1950.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs unit tests on Android emulator for both
x86andx86_64.Tracking issue: #1778
Foundation to test #1947.