refactor(udp): introduce log facade #1935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ralith
requested changes
Jul 23, 2024
|
Good point @Ralith. Thanks. Mind taking another look? |
djc
reviewed
Jul 25, 2024
Ralith
reviewed
Jul 25, 2024
Ralith
approved these changes
Jul 27, 2024
djc
approved these changes
Aug 1, 2024
Add `log` facade that either dispatches to `tracing` or `log`, or to a no-op implementation.
|
As discussed, I moved the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
logfacade that either dispatches totracingorlog, or to a no-op implementation.As suggested in #1932 (review).