Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail FreeBSD CI if any step fails #1557

Merged
merged 2 commits into from
May 6, 2023
Merged

Conversation

Tirka
Copy link
Contributor

@Tirka Tirka commented May 6, 2023

FreeBSD CI Action gives false success results. Here is possible explanation: #1556

Removing fuzz tests is not ideal, but better than getting false success CI check results on every run

@Ralith
Copy link
Collaborator

Ralith commented May 6, 2023

Maybe combine all the commands with && instead, to explicitly propagate failures?

@Tirka
Copy link
Contributor Author

Tirka commented May 6, 2023

Maybe combine all the commands with && instead, to explicitly propagate failures?

Done. Looks good to me

Copy link
Collaborator

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Ralith Ralith changed the title remove fuzz tests on freebsd Fail FreeBSD CI if any step fails May 6, 2023
@Ralith Ralith merged commit 37e7b74 into quinn-rs:main May 6, 2023
@Tirka Tirka deleted the fix-freebsd-ci branch May 6, 2023 18:47
@djc djc mentioned this pull request May 8, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants