Fix racy Endpoint::wait_idle

quinn-rs · Jan 8, 2023 · 112a2f6 · 112a2f6
1 parent c88a6ec
commit 112a2f6
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/quinn/src/endpoint.rs b/quinn/src/endpoint.rs
@@ -271,8 +271,10 @@ impl Endpoint {
                 if endpoint.connections.is_empty() {
                     break;
                 }
+                // Construct future while lock is held to avoid race
+                self.inner.shared.idle.notified()
             }
-            self.inner.shared.idle.notified().await;
+            .await;
         }
     }
 }