Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added release.yaml GitHub workflow #101

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Saw-mon-and-Natalie
Copy link
Contributor

This PR adds a release.yaml workflow to build nightly and tagged binaries.

closes #100 .

@Saw-mon-and-Natalie
Copy link
Contributor Author

@SamWilsn , @lightclient , I'd appreciate a review.

PS. on the right sidebar, there isn't an option to assign reviewers.

uses: actions/checkout@v2

# Moves the `nightly` tag to `HEAD`
- name: Move nightly tag
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've always understood that tags are supposed to be immutable. What's the advantage over a nightly branch, or a series of nightly-2022-05-05 tags?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a particular reason for ETK. This workflow follows the process for Foundry. I think in this case keeping track of one nightly build would be enough.

@SamWilsn should we just make it so that it keeps track of only one nightly tag?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So sorry for not replying sooner!

I'm strongly opposed to moving a tag. I'd much prefer a series of nightly-YYYY-MM-DD tags that never change, and possibly a nightly branch that points to the latest one.

That said, I'm not even sure there's much value in tagging nightlies? Considering how slowly we develop ETK, I think we could make do with publishing binaries only for numbered releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add release binaries
2 participants