-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add POST_LOAD_ASDF_SYSTEMS option to build #672
Conversation
Add POST_LOAD_ASDF_SYSTEMS which adds systems to be built and loaded in the executable file. This allows for external sysytems to extend quilc and be built into the executable without being part of the quilc system.
This mostly helps in building the quilc executable. Obviously one can make new ASDF systems that depend on CL-QUIL and/or QUILC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you document this new variable in the README?
Added a new section in the README with a table for build options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
V cool addition
Move all references to POST_LOAD_ASDF_SYSTEMS to where it is used and remove top-level export. This also fixes some string-eval issues
1c8622a
to
ae51495
Compare
@notmgsk ping |
Add POST_LOAD_ASDF_SYSTEMS which adds systems to be built and loaded in
the executable file. This allows for external sysytems to extend quilc
and be built into the executable without being part of the quilc system.