Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add POST_LOAD_ASDF_SYSTEMS option to build #672

Merged
merged 5 commits into from
Sep 22, 2020

Conversation

colescott
Copy link
Member

Add POST_LOAD_ASDF_SYSTEMS which adds systems to be built and loaded in
the executable file. This allows for external sysytems to extend quilc
and be built into the executable without being part of the quilc system.

Add POST_LOAD_ASDF_SYSTEMS which adds systems to be built and loaded in
the executable file. This allows for external sysytems to extend quilc
and be built into the executable without being part of the quilc system.
@colescott colescott requested a review from a team as a code owner August 17, 2020 17:20
@stylewarning
Copy link
Member

This mostly helps in building the quilc executable. Obviously one can make new ASDF systems that depend on CL-QUIL and/or QUILC.

Copy link
Member

@stylewarning stylewarning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you document this new variable in the README?

build-app.lisp Outdated Show resolved Hide resolved
build-app.lisp Outdated Show resolved Hide resolved
@colescott
Copy link
Member Author

can you document this new variable in the README?

Added a new section in the README with a table for build options

stylewarning
stylewarning previously approved these changes Aug 31, 2020
Copy link
Member

@stylewarning stylewarning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@notmgsk notmgsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V cool addition

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
build-app.lisp Outdated Show resolved Hide resolved
Move all references to POST_LOAD_ASDF_SYSTEMS to where it is used and
remove top-level export. This also fixes some string-eval issues
@stylewarning
Copy link
Member

@notmgsk ping

@notmgsk notmgsk merged commit c292f76 into master Sep 22, 2020
@stylewarning stylewarning deleted the makefile-add-external-systems branch September 22, 2020 17:42
@notmgsk notmgsk mentioned this pull request Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants