Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libdovi: MMR coefficients always start with a zeroed array #197

Closed
quietvoid opened this issue Jan 13, 2023 · 0 comments
Closed

libdovi: MMR coefficients always start with a zeroed array #197

quietvoid opened this issue Jan 13, 2023 · 0 comments
Milestone
libdovi 3.0

Comments

@quietvoid
Copy link
Owner

quietvoid commented Jan 13, 2023 •
edited
Loading

This is wrong and it's caused by the parsing allocating an extra array.
However the writing has the same bug so it writes the right coefficients, resulting in identical output.

Users of the mmr_coef{_int} array are the only ones affected by this bug.
@quietvoid quietvoid changed the title libdoiv: MMR coefficients always start with a zeroed array libdovi: MMR coefficients always start with a zeroed array Jan 13, 2023
@quietvoid quietvoid added this to the libdovi 3.0 milestone Jan 14, 2023
quietvoid added a commit that referenced this issue Jan 16, 2023
@quietvoid
Refactor libdovi structs
96a3a8e 
Peak memory reduced by ~25%.
RPU parsing performance improved by ~20%.
RPU encoding performance improved by ~7%.

Fixes #197.
quietvoid added a commit that referenced this issue Jan 16, 2023
@quietvoid
Refactor libdovi structs
23bb4c7 
Peak memory reduced by ~25%.
RPU parsing performance improved by ~20%.
RPU encoding performance improved by ~7%.

Fixes #197.
quietvoid added a commit that referenced this issue Jan 16, 2023
@quietvoid
Refactor libdovi structs
fc3cb1e 
Peak memory reduced by ~25%.
RPU parsing performance improved by ~20%.
RPU encoding performance improved by ~7%.

Fixes #197.
quietvoid added a commit that referenced this issue Jan 16, 2023
@quietvoid
Refactor libdovi structs
b9f061f 
Peak memory reduced by ~25%.
RPU parsing performance improved by ~20%.
RPU encoding performance improved by ~7%.

Fixes #197.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
libdovi 3.0
Development

No branches or pull requests
1 participant
@quietvoid