kustomize: persist DB_URI for managed postgres (PROJQUAY-1635) #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecmerdler
force-pushed
the
PROJQUAY-1635
branch
3 times, most recently
from
7dbea33
to
84ea60b
Compare
alecmerdler
commented
Apr 28, 2021
| @@ -6,8 +6,6 @@ metadata: | |||
| quay-component: postgres | |||
| spec: | |||
| replicas: 1 | |||
| strategy: | |||
There was a problem hiding this comment.
Note: the Postgres pod will still be recreated, but changing the strategy to type: RollingUpdate and persisting the password across reconciles means the database will remain available.
alecmerdler
force-pushed
the
PROJQUAY-1635
branch
from
84ea60b
to
bdcd0b5
Compare
alecmerdler
commented
Apr 28, 2021
.github/workflows/ci.yaml
Outdated
| curl -L https://go.kubebuilder.io/dl/2.3.1/${os}/${arch} | tar -xz -C /tmp/ | ||
| mv /tmp/kubebuilder_2.3.1_${os}_${arch} /usr/local/kubebuilder | ||
| export PATH=$PATH:/usr/local/kubebuilder/bin | ||
| curl -L -o kubebuilder https://go.kubebuilder.io/dl/latest/$(go env GOOS)/$(go env GOARCH) |
There was a problem hiding this comment.
Kubebuilder installation changed: https://book.kubebuilder.io/quick-start.html#installation
alecmerdler
force-pushed
the
PROJQUAY-1635
branch
from
bdcd0b5
to
6cc7f71
Compare
Change DB_URI to be persisted rather than generated on each reconcile. This prevents downtime on reconciles because the old and new Quay pods continue to use the same database password. Signed-off-by: Alec Merdler <alecmerdler@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change DB_URI to be persisted rather than generated on each
reconcile. This prevents downtime on reconciles because the old and
new Quay pods continue to use the same database password.
Signed-off-by: Alec Merdler alecmerdler@gmail.com