Add package_kind to vulnerability query #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allda
requested review from
alecmerdler,
hdonnay,
jzelinskie and
ldelossa
as code owners
Allda
force-pushed
the
package_kind_query
branch
from
4b3cad5
to
ab911ba
Compare
|
@ldelossa I change a query to doesn't require package kind if it is not defined in vulnerability. This way updaters that support package kinds have more precise matching results and updaters that doesn't support it yet are not affected by this change. |
Allda
force-pushed
the
package_kind_query
branch
2 times, most recently
from
23eecb9
to
e20862e
Compare
By adding package kind to database vulnerability query we query only real affected packages. Without this code Clair produce false negatives in case source package and binary package has same name. When vulnerability is issued with source package all binary package that have come from same source are marked as vulnerable.
Allda
force-pushed
the
package_kind_query
branch
from
e20862e
to
9a9b777
Compare
ldelossa
approved these changes
Aug 19, 2020
ldelossa
pushed a commit
that referenced
this pull request
Aug 23, 2020
By adding package kind to database vulnerability query we query only real affected packages. Without this code Clair produce false negatives in case source package and binary package has same name. When vulnerability is issued with source package all binary package that have come from same source are marked as vulnerable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding package kind to database vulnerability query we query only
real affected packages. Without this code Clair produce false negatives
in case source package and binary package has same name.
When vulnerability is issued with source package all binary package that
have come from same source are marked as vulnerable.