updaters: handle "unchanged" better #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
still need to spot-check the other updaters |
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
ldelossa
approved these changes
Jul 13, 2020
| @@ -58,18 +58,16 @@ func (u *Updater) Fetch(ctx context.Context, hint driver.Fingerprint) (io.ReadCl | |||
|
|
|||
| var r io.Reader = res.Body | |||
| if _, err := io.Copy(tf, r); err != nil { | |||
| tf.Close() | |||
There was a problem hiding this comment.
Suggested change
| tf.Close() | |
| if tf != nil { | |
| tf.Close() | |
| } |
I've gotten into the habit of checking nil on these things first, may not be necessary.
There was a problem hiding this comment.
In this case, tmp.File works such that if it didn't return an error, it can't return a nil pointer.
| } | ||
| } | ||
|
|
||
| func (f *fingerprint) From(h http.Header) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debian and ubunut updaters weren't actually checking the passed-in fingerprint, which was resulting in spurious updates in the database.
The alpine updater wasn't using an etag, which the remote server seems to support, so this change uses that.