add consistent linux bridge name #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldelossa
requested review from
alecmerdler,
hdonnay and
jzelinskie
as code owners
Signed-off-by: ldelossa <ldelossa@redhat.com>
ldelossa
force-pushed
the
louis/firewalld-docker-compose
branch
from
9d42593
to
b7c0aa0
Compare
hdonnay
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like to keep firewalld enabled on my fedora machine.
Docker compose creates a user defined network and usually the linux bridge interface it creates has a random name and this makes it difficult to place into firewalld zone rules.
This PR makes the local-dev linux bridge interface hosting the local dev network a consistent name.
Signed-off-by: ldelossa ldelossa@redhat.com