Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement updater sets #164

Merged
merged 5 commits into from
Apr 27, 2020
Merged

implement updater sets #164

merged 5 commits into from
Apr 27, 2020

Conversation

ldelossa
Copy link
Contributor

This PR creates a container object for working with sets of Updaters.
UpdaterSet data structures do not allow duplicate names to be added.

Part of this work is to clean up libvuln for further initialization logic to occur.

libvuln/driver/updaterset.go Outdated Show resolved Hide resolved
libvuln/driver/updaterset.go Outdated Show resolved Hide resolved
libvuln/opts.go Outdated Show resolved Hide resolved
libvuln/driver/updaterset.go Outdated Show resolved Hide resolved
libvuln/opts.go Outdated Show resolved Hide resolved
@ldelossa
Copy link
Contributor Author

ldelossa commented Apr 25, 2020

@hdonnay latest commits add the ability to provide a pointer to a slice of strings for updater sets. Each string will specify an updater set.

If the slice is nil, all updaters are constructed and launched.
If the slice is empty, no updaters are launched
If the slice is not empty, only the specified updater sets are launched.

ldelossa added 3 commits April 27, 2020 11:40
this commit adds the ability to specify individual updater sets
via libvuln opts.

some config values are removed as well as they may have been exposed
too soon.
libvuln/driver/updaterset.go Outdated Show resolved Hide resolved
libvuln/opts.go Outdated Show resolved Hide resolved
libvuln/opts.go Outdated Show resolved Hide resolved
libvuln/updatesets.go Outdated Show resolved Hide resolved
libvuln/updatesets.go Show resolved Hide resolved
Copy link
Member

@hdonnay hdonnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldelossa ldelossa merged commit 2420373 into master Apr 27, 2020
@ldelossa ldelossa deleted the louis/updater-set branch April 27, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants