Rpm module vulnerability matching #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allda
requested review from
alecmerdler,
hdonnay,
jzelinskie and
ldelossa
as code owners
ldelossa
suggested changes
Apr 9, 2020
Module name and stream is parsed from oval files and associated with appropriate rpm packages. Module information is stored in vuln database table.
New PackageModule is added to MatchConstraint. This constraint queries vulnerability with matching module name. When package is not part of a module it can be vulnerable only to non-modular vulnerabilities.
Rhel matcher now supports rpm module vulnerability. Only package vulnerabilities within same module will be reported. Other non-modular rpms will not be affected by this change because non-modular rpms contains empty module.
Module regex is created only once at a beginning.
package_module is used to query vulnerability.
Cache key contains package and module name. The cache reduce size of oval data.
Allda
force-pushed
the
module-vulnerability
branch
from
78b9e42
to
b4f4194
Compare
ldelossa
approved these changes
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains support for modular rpm vulnerability matching.
Modular rpm is a special type of rpm package which needs to be handled in a different way from normal rpms. Oval contains module metadata that determines the affected module + stream. Module metadata is stored in a vuln table and queried using new MatchConstraint.