Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make python package name case insensitive #146

Merged
merged 4 commits into from
Mar 23, 2020
Merged

Make python package name case insensitive #146

merged 4 commits into from
Mar 23, 2020

Conversation

arajkumar
Copy link
Contributor

@arajkumar arajkumar commented Mar 23, 2020 •
edited
Loading

The image ararunprasad/flask-0.12 has vulnerable Flask version 0.12 , but it is not flagged by Claircore due to case-sensitive name comparison.

./cctool report ararunprasad/flask-0.12

Actually I couldn't write a test for this fix because the package name equality has been done through SQL query. Correct me If I'm wrong.

ldelossa
ldelossa approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@ldelossa ldelossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. it looks safe for our application to normalize.
thanks for removing the dead code.

@ldelossa ldelossa merged commit 163e871 into quay:master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldelossa ldelossa ldelossa approved these changes

@alecmerdler alecmerdler Awaiting requested review from alecmerdler

@hdonnay hdonnay Awaiting requested review from hdonnay

@jzelinskie jzelinskie Awaiting requested review from jzelinskie

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arajkumar @ldelossa