Louis/remove db coalescer #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 15, 2020 16:54
ldelossa
force-pushed
the
louis/remove-db-coalescer
branch
from
a22ea1c
to
8881690
Compare
ldelossa
force-pushed
the
louis/remove-db-coalescer
branch
from
8881690
to
573ec7f
Compare
hdonnay
requested changes
Jan 17, 2020
internal/indexer/linux/coalescer.go
Outdated
| @@ -23,18 +22,12 @@ type layerArtifacts struct { | |||
| // for dpkg, os-release, and apt scanners | |||
| type Coalescer struct { | |||
| // a store to access scanartifacts | |||
hdonnay
previously approved these changes
Jan 29, 2020
|
Just dealt with merge conflicts. The new Digest type makes it tough to test arbitrary layer fixtures. |
ldelossa
force-pushed
the
louis/remove-db-coalescer
branch
from
8de852c
to
9cc28eb
Compare
ldelossa
force-pushed
the
louis/remove-db-coalescer
branch
from
9cc28eb
to
cd147dd
Compare
hdonnay
approved these changes
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the indexer's Store implementation from the Coalescer implementations. This is step one to moving internal indexer interfaces to a driver package.