themes: use content hash in cache key and output file name #10611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cscheid
changed the title
revealjs themes: use content hash in cache key and output file name
cderv
reviewed
Aug 27, 2024
There was a problem hiding this comment.
Really nice fix for the revealjs problem ! Thanks a lot.
I want to open a discussion on some other change for websites and bootstrap themes. I commented below, but we can also discuss this live - could be easier than in writing here.
I mostly want to make sure I understand correctly the impact, as I though current design choice was Bootstrap website themes should always win.
cscheid
changed the title
revealjs themes: use content hash in cache key and output file name
|
🔥 awesome and a lot shorter than I expected! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes one of the longstanding Quarto SCSS bugs with theming.
Now, different files in the same website can have different themes and they will each have their own CSS file.
This currently applies to:
bootstrap.min.css, which is now emitted asbootstrap-${hash}.min.css, wherehashis the MD5 hash of the output. This file is generated byhtmlanddashboardboth.quarto.css, the name of the css file in revealjs themes.quarto-syntax-highlighting.css, the CSS file responsible for syntax highlighting.We need unit and regression tests as well as a whole lot of early user testing on this one.
This closes #10369, #10087, #8383 (and likely others that I haven't found)