Eclipse apt fixes #716
Eclipse apt fixes #716
Conversation
| @@ -149,7 +151,7 @@ void doFinish(RoundEnvironment roundEnv) { | |||
| return; | |||
| } | |||
| final URI uri = tempResource.toUri(); | |||
| tempResource.delete(); | |||
| // tempResource.delete(); | |||
There was a problem hiding this comment.
This looks fine, it's an empty file anyway and should do no harm I would think if it stays around.
There was a problem hiding this comment.
Why do we need to keep it around? Can't we delete it at some point?
There was a problem hiding this comment.
@FroMage out of curiosity, could you explain why we need to keep the file? A comment might help if we need to keep it this way.
There was a problem hiding this comment.
We're not keeping that file: Eclipse throws if you try to delete it, and we write to it just below.
There was a problem hiding this comment.
Well we don't really write to it, we just use it to find the path and get the parent path. So we can still delete it if we find a way to make Eclipse happy about it, though like I said it's not really too important.
|
OK to merge once CI reports in. |
|
Looks like it failed, can you tell me why? I don't have permissions to log in the CI. |
|
@FroMage not related to this PR, it fails very late when testing the CLI tools. |
|
Ah. Damn. So… what now? |
you ignore it & merge |
|
Fair enough, thanks :) |
Temporary workarounds for #713