Add a note about let's encrypt challenge requiring the port 80 to be accessible #43070
Conversation
|
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
cescoffier
force-pushed
the
lets-encrypt-port-80
branch
from
b89bfa4
to
188490b
Compare
Status for workflow
|
|
Hello @cescoffier ! I just added one asciidoc fix and a bunch of tiny suggestions. Cheers! |
cescoffier
force-pushed
the
lets-encrypt-port-80
branch
from
188490b
to
8091d15
Compare
|
@MichalMaler I've applied your suggestions! Thanks! |
This comment has been minimized.
This comment has been minimized.
…accessible Also changes the document category and added an Id.
cescoffier
force-pushed
the
lets-encrypt-port-80
branch
from
8091d15
to
2871848
Compare
Status for workflow
|
There was a problem hiding this comment.
LGTM, thanks @cescoffier for dealing with all the comments , cheers
The Let's Encrypt challenge requires port 80 to be accessible. The guide should have mentioned this.
Also, I realized that the category was not part of the known category, so I switched to "web" (even if "network" was better). Finally, the build complained about a missing document ID. I added one.