Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Agroal pool logging #43023

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Sep 4, 2024

In Quarkus LangChain4j, we ended up with log entries like:

2024-09-04 15:59:04,507 INFO [io.agr.pool] (executor-thread-1) Datasource '': Pool interceptors: [io.quarkiverse.langchain4j.pgvector.PgVectorAgroalPoolInterceptor_X57UyAR6Zcr9HEqaFpEAQVtGhO8_Synthetic_ClientProxy@762e5bc7 (priority 0)]

It's not something the user should be bothered with.

Note that Luis will give us more flexibility in a future Agroal version so that we can specifically filter out this message but I'm not sure we will be able to backport the update so this will do until we do better.

In Quarkus LangChain4j, we ended up with log entries like:
2024-09-04 15:59:04,507 INFO  [io.agr.pool] (executor-thread-1) Datasource '<default>': Pool interceptors: [io.quarkiverse.langchain4j.pgvector.PgVectorAgroalPoolInterceptor_X57UyAR6Zcr9HEqaFpEAQVtGhO8_Synthetic_ClientProxy@762e5bc7 (priority 0)]

It's not something the user should be bothered with.
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 4, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit c75211d.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 integration-tests/grpc-hibernate

com.example.grpc.hibernate.BlockingRawTest.shouldAdd - History

  • Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at com.example.grpc.hibernate.BlockingRawTestBase.shouldAdd(BlockingRawTestBase.java:59)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

@gsmet gsmet merged commit 9241263 into quarkusio:main Sep 5, 2024
42 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Sep 5, 2024
@gsmet gsmet modified the milestones: 3.16 - main, 3.14.3 Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants