Properly escape log message additions #43019
Merged
+35
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
force-pushed
the
fix-log-fmt
branch
2 times, most recently
from
1f9d448
to
9474aa6
Compare
Also ensure that the proper format style is preserved. Avoids various NPE, IAE, etc. exceptions when rendering log messages that have been decorated.
gsmet
approved these changes
Sep 4, 2024
|
@dmlloyd I stumbled upon one funky issue here: if you log the exception twice, you will add the information twice. I understand it's not your typical thing but I wonder if we should add a marker that we already added the parameter to the record? |
|
TBH this shouldn't be done in this way at all. Manipulating the log record at some random time is incorrect for exactly this reason - it could be used by many formatters, serialized, etc. Maybe this would be better done as a filter on the root logger? |
|
The best solution would be to support this in the logmanager itself via something in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also ensure that the proper format style is preserved. Avoids various NPE, IAE, etc. exceptions when rendering log messages that have been decorated.
/cc @gsmet
Fixes #43021