Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSockets Next: support endpoints with empty path #42830

Merged
merged 1 commit into from
Aug 29, 2024
Merged

WebSockets Next: support endpoints with empty path #42830

merged 1 commit into from
Aug 29, 2024

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Aug 28, 2024

@mkouba mkouba mentioned this pull request Aug 28, 2024
Closed
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@mkouba mkouba requested a review from cescoffier August 28, 2024 13:23
gsmet
gsmet approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a small comment. Feel free to ignore and merge if you don't see value to it.

...ts-next/runtime/src/main/java/io/quarkus/websockets/next/runtime/WebSocketConnectorBase.java Outdated Show resolved Hide resolved
@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 29, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 29, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 4915cad.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@mkouba mkouba merged commit 95a246a into quarkusio:main Aug 29, 2024
20 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Aug 29, 2024
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Aug 29, 2024
@gsmet gsmet modified the milestones: 3.16 - main, 3.14.2 Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
kind/bugfix
Projects
WG - WebSocket Next
Status: Done
Milestone
3.14.2
Development

Successfully merging this pull request may close these issues.

quarkus-websockets-next client adds / to empty path
3 participants
@mkouba @cescoffier @gsmet