Register resource classes for reflection when ContainerResponseFilter exists

[geoand]

This is needed because those filters can call
setEntityStream which then forces the use of the
slow path for calling writers

• Closes: REST usage fails with native when e.g. ContainerResponseFilter is used #42537

[FroMage]

I'm not sure your comment is accurate, the original issue is not about setEntityStream but obtaining annotations on the filtered resource/method.

Also, the original issue uses ContainerRequestFilter which must go through reflection to obtain annotations, while our docs advise @ServerRequestFilter which can probably obtain method annotations without registering the entire class for reflection (to be checked). So, is this new test taking this into account and only adding reflection for ContainerRequestFilter and not @ServerRequestFilter?

Or are they equally broken ATM?

Last, adding a test would probably save us a future headache :)

[geoand]

the original issue is not about setEntityStream but obtaining annotations on the filtered resource/method.

Yes and no. It's correct as the condition under which the error happens only occurs when ContainerResponseFilter#setEntityStream is used.

Also, the original issue uses ContainerRequestFilter

Both the title and the reproducer use ContainerResponseFilter.

Last, adding a test would probably save us a future headache :)

Sure, I'll add one.

[geoand]

PR updated with a test

[FroMage]

Both the title and the reproducer use ContainerResponseFilter.

My question was badly formulated, but I meant to ask whether @ServerRequestFilter also required reflection?

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 2a050f7.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

---

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/infinispan-cache/deployment

✖ io.quarkus.cache.infinispan.InfinispanCacheTest.testGetAsyncWithParallelCalls - History

• expected: "thread1" but was: "thread2" - org.opentest4j.AssertionFailedError

org.opentest4j.AssertionFailedError: 

expected: "thread1"
 but was: "thread2"
	at io.quarkus.cache.infinispan.InfinispanCacheTest.testGetAsyncWithParallelCalls(InfinispanCacheTest.java:283)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:499)
	at io.quarkus.test.QuarkusUnitTest.interceptTestMethod(QuarkusUnitTest.java:413)

---

⚙️ Native Tests - HTTP

📦 integration-tests/rest-client-reactive

✖ io.quarkus.it.rest.client.BasicTestIT.shouldCreateClientSpans - History

• expected: <1> but was: <2> - org.opentest4j.AssertionFailedError

org.opentest4j.AssertionFailedError: expected: <1> but was: <2>
	at io.quarkus.it.rest.client.BasicTest.shouldCreateClientSpans(BasicTest.java:216)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:821)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

[FroMage]

Yes and no. It's correct as the condition under which the error happens only occurs when ContainerResponseFilter#setEntityStream is used.

Oh, OK, I thought it was only due to using Method to obtain the annotations.

[geoand]

👍🏽