Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the root path for OpenContainerPathTree#getRoots() #42588

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Aug 16, 2024

The container path is the path of the container (could be a directory or an archive and shouldn't be used for browsing.
The root path is the path of the root. In the case of an archive, it's actually a ZipPath, which can be used to browse the archive.

Fixes #42571
Follows up #42492

The container path is the path of the container (could be a directory or
an archive and shouldn't be used for browsing.
The root path is the path of the root. In the case of an archive, it's
actually a ZipPath, which can be used to browse the archive.

Fixes quarkusio#42571
@gsmet gsmet requested a review from aloubyansky August 16, 2024 12:12
@quarkus-bot quarkus-bot bot added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label Aug 16, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 16, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 6dd6150.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 integration-tests/grpc-hibernate

com.example.grpc.hibernate.BlockingRawTest.shouldAdd - History

  • Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at com.example.grpc.hibernate.BlockingRawTestBase.shouldAdd(BlockingRawTestBase.java:59)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

@gsmet gsmet merged commit d42baa5 into quarkusio:main Aug 16, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Aug 16, 2024
@gsmet gsmet modified the milestones: 3.16 - main, 3.13.3 Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins kind/bugfix triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qute template detection has changed on Windows for templates in project dependencies
2 participants