-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing documentation regarding OIDC with GitHub #42548
Conversation
Technically this was a breaking change, so not sure if you'd like to fix it in different ways? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Sanne, FYI, I copied all of these images from Renarde to Quarkus to have a better coverage of how to manage the social provider registrations, but these docs are not meant to provide the correct Renarde info, so please check the Renarde docs for the uptodate content/images.
Let's fix it here too though to minimize the confusion and I guess we should bring more neutral images later
Hi @Sanne, it is all good, this all is managed at the Renarde level. Here, in Quarkus, these are just sample images, we should replace them in the future |
Status for workflow
|
🙈 The PR is closed and the preview is expired. |
ah, I guess that's why this section had not been updated when the changes were made. Thanks that's a bit more reassuring! cc/ @FroMage for awareness |
Fix #42546
Includes a new screenshot with the corrected example.