Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing documentation regarding OIDC with GitHub #42548

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

Sanne
Copy link
Member

@Sanne Sanne commented Aug 14, 2024

Fix #42546

Includes a new screenshot with the corrected example.

@Sanne
Copy link
Member Author

Sanne commented Aug 14, 2024

Technically this was a breaking change, so not sure if you'd like to fix it in different ways?
Also, might need to figure out when this changed exactly.

Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Sanne, FYI, I copied all of these images from Renarde to Quarkus to have a better coverage of how to manage the social provider registrations, but these docs are not meant to provide the correct Renarde info, so please check the Renarde docs for the uptodate content/images.

Let's fix it here too though to minimize the confusion and I guess we should bring more neutral images later

@sberyozkin
Copy link
Member

Hi @Sanne, it is all good, this all is managed at the Renarde level. Here, in Quarkus, these are just sample images, we should replace them in the future

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 14, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit cc7bc0b.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Copy link

github-actions bot commented Aug 14, 2024

🙈 The PR is closed and the preview is expired.

@sberyozkin sberyozkin merged commit 8c0b15b into quarkusio:main Aug 14, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Aug 14, 2024
@Sanne
Copy link
Member Author

Sanne commented Aug 14, 2024

I copied all of these images from Renarde to Quarkus to [...]

ah, I guess that's why this section had not been updated when the changes were made. Thanks that's a bit more reassuring!

cc/ @FroMage for awareness

@Sanne Sanne deleted the Fix42546 branch August 14, 2024 15:07
@gsmet gsmet modified the milestones: 3.16 - main, 3.14.0 Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Wrong callback URL in documentation for GitHub OIDC
3 participants