Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added office 365 email configuration #42539

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

Lory1990
Copy link
Contributor

Hi,
I passed the entire day to configure Office 365 and quarkus mailer but i did it!

So it is time to share the configuration with the community

@quarkus-bot

This comment has been minimized.

Copy link

github-actions bot commented Aug 14, 2024

🙈 The PR is closed and the preview is expired.

gsmet
gsmet previously requested changes Aug 14, 2024
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for sharing. That's exactly how it should be done!

I added a couple of suggestions.

I have one big question though: we were told that they were enforcing XOAuth now and that this configuration didn't work anymore? See #39359 for more context.

Thanks for your insights!

docs/src/main/asciidoc/mailer-reference.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/mailer-reference.adoc Outdated Show resolved Hide resolved
@Lory1990
Copy link
Contributor Author

I tried with this configuration and it did not work

quarkus.mailer.auth-methods=DIGEST-MD5 CRAM-SHA256 CRAM-SHA1 CRAM-MD5 PLAIN LOGIN
quarkus.mailer.start-tls=REQUIRED
quarkus.mailer.port=587
quarkus.mailer.ssl=true
quarkus.mailer.trust-all=true
quarkus.mailer.host=smtp.office365.com
quarkus.mailer.login=XOAUTH2
quarkus.mailer.from=xxxx
quarkus.mailer.username=xxx
quarkus.mailer.password=xxx

It fails with error

 Failed to create SSL connection
not an SSL/TLS record: 323230204d4931503239334341303031322e6f75746c6f6f6b2e6f66666963653336352e636f6d204d6963726f736f66742045534d5450204d41494c2053657276696365207265616479206174205468752c2031352041756720323032342031393a30363a3333202b30303030205b303844434243443534454645363346355d0d0a

On the other hand with this one

quarkus.mailer.auth-methods=DIGEST-MD5 CRAM-SHA256 CRAM-SHA1 CRAM-MD5 PLAIN LOGIN
quarkus.mailer.start-tls=REQUIRED
quarkus.mailer.port=587
quarkus.mailer.host=smtp.office365.com
quarkus.mailer.login=XOAUTH2
quarkus.mailer.from=xxxx
quarkus.mailer.username=xxx
quarkus.mailer.password=xxx

the error is

 io.vertx.ext.mail.SMTPException: recipient address not accepted: 501 5.1.5 Recipient address reserved by RFC 2606

@quarkus-bot

This comment has been minimized.

Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you please squash your commits and force-push so we can merge this?

docs/src/main/asciidoc/mailer-reference.adoc Outdated Show resolved Hide resolved
@quarkus-bot

This comment has been minimized.

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 19, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 35389fd.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gastaldi gastaldi requested a review from gsmet August 19, 2024 23:16
@gastaldi gastaldi dismissed gsmet’s stale review August 19, 2024 23:16

Suggestions applied

@gastaldi gastaldi merged commit 9f39e64 into quarkusio:main Aug 19, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Aug 19, 2024
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 19, 2024
@gsmet gsmet modified the milestones: 3.16 - main, 3.14.0 Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

5 participants