Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix group overriding with machine username #42218

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Conversation

thmasker
Copy link
Contributor

@thmasker thmasker commented Jul 30, 2024

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 30, 2024

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should not contain an issue number (use Fix #1234 in the description instead)

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins labels Jul 30, 2024
@thmasker thmasker changed the title Fixes #41968 Fix group overriding with machine username Fix group overriding with machine username Jul 30, 2024
@thmasker thmasker marked this pull request as ready for review July 30, 2024 09:21
@gastaldi gastaldi requested a review from iocanel July 30, 2024 14:32
@geoand
Copy link
Contributor

geoand commented Aug 1, 2024

Can you please rebase onto main?

Thanks

@gsmet
Copy link
Member

gsmet commented Aug 1, 2024

I did the rebase.

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@thmasker thmasker force-pushed the main branch 5 times, most recently from 1b90960 to 9325ff4 Compare August 2, 2024 12:21
@gsmet
Copy link
Member

gsmet commented Aug 2, 2024

@thmasker you don't need to rebase your PR. We are just waiting for @iocanel to have a look (but he might be on PTO).

@thmasker
Copy link
Contributor Author

thmasker commented Aug 2, 2024

@gsmet oh, ok. Since you wanted me to rebase previously...

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 2, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 2, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 791ab5e.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit aa1dce7 into quarkusio:main Aug 2, 2024
20 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Aug 2, 2024
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 2, 2024
@gsmet
Copy link
Member

gsmet commented Aug 3, 2024

Thanks for the PR! I will backport it to 3.13.1 that will be released next week.

@gsmet gsmet modified the milestones: 3.14 - main, 3.13.1 Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins kind/bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quarkus image build overrides container-image.group with the docker username
4 participants