Support Spring Data JpaRepository#getReferenceById(ID)

[aureamunoz]

Fixes #41987

[geoand]

Won't this change remove JpaRepository#getOne(ID)?
We should not remove it, but instead have the new method be an additional one

[geoand]

Furthermore, we should have tests using both the new and the deprecated method

[aureamunoz]

Initially, I thought about keeping the StockMethodsAdder#getOne method and adding a new one. However, since getOne was private and only used in one place, I decided to refactor it instead. I renamed the method and its variables to getReferenceById. As RepositorySupport#getOne is public, I didn't delete it. Instead, I marked it as @deprecated and added a new method, RepositorySupport@getReferenceById.

Regarding the tests I'm not sure to understand, I added a few tests using both. What do you exactly mean?

[geoand]

Regarding the tests I'm not sure to understand, I added a few tests using both. What do you exactly mean

I had missed those I guess. If these pass, we are fine

[aureamunoz]

Looking at this

[geoand]

The problem is likely what I mentione earlier: The change seems to have removed the implementation of the getOne method

[aureamunoz]

Yes, it seems to be a good reason to keep adding the deprecated methods implems 😆
I refactored and added a few more that were lacking.

Let's see what the CI says

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 4e06bfb.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

[famod]

Can this also be backported to 3.12? My reasoning would be that the Spring API update was also done in 3.12.

[geoand]

Sure yeah