Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update content for support of quarkus-oidc-token-propagation-(reactive) extensions #41938

Conversation

rolfedh
Copy link
Contributor

@rolfedh rolfedh commented Jul 16, 2024

The quarkus-oidc-token-propagation and quarkus-oidc-token-propagation-reactive extensions have tech preview status in 3.8 and later.

Therefore, this PR removes ifndef conditionals to ensure that content indicating support for those extensions is visible. Additionally, it removes ifdef conditionals along with the non-support content they contain.

…-rest-client-oidc-token-propagation support in RHBQ
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 16, 2024

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should not end up with ellipsis (make sure the title is complete)

This message is automatically generated by a bot.

@rolfedh rolfedh marked this pull request as draft July 16, 2024 18:22
@rolfedh rolfedh requested a review from sberyozkin July 16, 2024 18:22
@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation labels Jul 16, 2024
@rolfedh rolfedh requested a review from rsvoboda July 16, 2024 18:22
@rolfedh rolfedh changed the title Update for quarkus-resteasy-client-oidc-token-propagation and quarkus… Update content for support of extensions in RHBQ 3.14 Jul 16, 2024
@rolfedh
Copy link
Contributor Author

rolfedh commented Jul 16, 2024

@rsvoboda @sberyozkin let's use this one and close #41914, okay?

@rolfedh rolfedh changed the title Update content for support of extensions in RHBQ 3.14 Update content for support of quarkus-oidc-token-propagation-(reactive) extensions Jul 17, 2024
@rolfedh rolfedh marked this pull request as ready for review July 17, 2024 11:23
@rolfedh rolfedh requested a review from gsmet July 17, 2024 11:23
Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, they are in stable state now, but let Rostislav decide if he'd like to keep these exclusions for longer in the docs

@rsvoboda rsvoboda merged commit da74db3 into quarkusio:main Jul 17, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Jul 17, 2024
Copy link

🙈 The PR is closed and the preview is expired.

@rolfedh rolfedh removed the request for review from gsmet July 17, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docstyle issues related for manual docstyle review area/documentation
Projects
Development

Successfully merging this pull request may close these issues.

3 participants