Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle imageTask: look for builders among the dependencies of the runtime Quarkus application configuration instead of all the project configurations #41894

Merged

Conversation

aloubyansky
Copy link
Member

Fix #41729

@iocanel does this make sense to you? Am I missing something? Thanks.

@aloubyansky aloubyansky requested a review from iocanel July 15, 2024 11:57
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle labels Jul 15, 2024
@quarkus-bot

This comment has been minimized.

@aloubyansky aloubyansky added triage/backport-2.13 triage/backport and removed area/gradle Gradle area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins triage/backport-2.13 labels Jul 15, 2024
@Malandril
Copy link
Contributor

This PR seems to create another issue

When i test with a sample project with the jib extension quarkus create app --gradle-kotlin-dsl -x 'quarkus-rest, jib' quarkus-concurrent-bug

Running with this PR the imageBuild task returns the following:

Task: imageBuild requires extensions: quarkus-container-image-docker
To add the extensions to the project you can run the following command:
        gradle addExtension --extensions=quarkus-container-image-docker

Switching back to quarkus 3.11.3, the image is built correctly

…time Quarkus application configuration instead of all the project configurations
@aloubyansky aloubyansky force-pushed the imageTask-finalRuntimConfigName branch from b69e6b3 to 202eb36 Compare July 17, 2024 08:51
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle labels Jul 17, 2024
@aloubyansky
Copy link
Member Author

Thanks for testing @Malandril. Should be fixed now.

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 17, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 202eb36.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet
Copy link
Member

gsmet commented Jul 22, 2024

@aloubyansky should we include it in 3.13 or do you want to wait?

@aloubyansky
Copy link
Member Author

I think it's worth including it

Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aloubyansky aloubyansky merged commit 026b1ac into quarkusio:main Jul 26, 2024
21 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Jul 26, 2024
@gsmet gsmet modified the milestones: 3.14 - main, 3.13.1 Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle kind/bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gradle imageBuild fails with java.util.ConcurrentModificationException quarkus 3.12.1
5 participants