Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] Apply QE feedback to community docs #41834

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

rolfedh
Copy link
Contributor

@rolfedh rolfedh commented Jul 11, 2024

Cherry Picked from abd49d0
xref: #41712

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 11, 2024

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • description should not be empty, describe your intent or provide links to the issues this PR is fixing (using Fixes #NNNNN) or changelogs

This message is automatically generated by a bot.

@rolfedh rolfedh marked this pull request as draft July 11, 2024 15:37
@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation labels Jul 11, 2024
@rolfedh rolfedh closed this Jul 11, 2024
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Jul 11, 2024
@rolfedh rolfedh reopened this Jul 11, 2024
@quarkus-bot quarkus-bot bot removed the triage/invalid This doesn't seem right label Jul 11, 2024
@quarkus-bot

This comment has been minimized.

@rolfedh
Copy link
Contributor Author

rolfedh commented Jul 11, 2024

Prequalified the synchronization job by using the "Try ingesting from an upstream pull request" pipeline schedule to create https://gitlab.cee.redhat.com/quarkus-documentation/quarkus/-/jobs/23660960 .

@rolfedh rolfedh marked this pull request as ready for review July 11, 2024 19:29
@michalvavrik
Copy link
Member

Cherry Picked from abd49d0

hey, I don't have time ATM to check 3.8 branch. cherry picking is not enough, because places where xref is in the main branch may or may not equal places where xref is in 3.8. Please double check that there are no additional xrefs in 3.8 and confirm. thank you Rolfe

@rolfedh rolfedh marked this pull request as draft July 12, 2024 13:20
@rolfedh rolfedh marked this pull request as ready for review July 12, 2024 18:49
@rolfedh
Copy link
Contributor Author

rolfedh commented Jul 12, 2024

Please double check that there are no additional xrefs in 3.8 and confirm. thank you Rolfe

Good point, @michalvavrik. I've gone back and searched the repo to ensure that all the updated IDs are correctly referenced by all other files. There are no additional unaccounted-for references. Thanks for asking.

@gsmet gsmet requested a review from sberyozkin July 18, 2024 07:06
@rolfedh
Copy link
Contributor Author

rolfedh commented Jul 18, 2024

When all PRs are approved and merged in the following order, I should finally be able to synch and publish the Security Guides for RHBQ 3.8:

  1. [3.8] Apply QE feedback to community docs #41834
  2. Remove conditionalization from Wiremock section #41977
  3. [3.8] Remove conditionalization from Wiremock section #41980

@rolfedh rolfedh requested a review from sberyozkin July 19, 2024 02:30
@sberyozkin
Copy link
Member

Thanks @rolfedh, please follow up with #41980 afterwards once Guillaume merges

@sberyozkin sberyozkin merged commit ada2a55 into quarkusio:3.8 Jul 19, 2024
5 checks passed
@sberyozkin sberyozkin deleted the cp-41712-to-3.8-bis branch July 19, 2024 14:14
Copy link

🙈 The PR is closed and the preview is expired.

@gsmet gsmet added this to the 3.8.6 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docstyle issues related for manual docstyle review area/documentation
Projects
Development

Successfully merging this pull request may close these issues.

4 participants