Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly close AsyncFile in Quarkus REST #41824

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jul 11, 2024

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 11, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit a010cbd.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
✔️ Kubernetes Tests - JDK 17 Logs Raw logs 🔍
Kubernetes Tests - JDK 21 Build ⚠️ Check → Logs Raw logs 🚧
✔️ Kubernetes Tests - JDK 17 Windows Logs Raw logs 🔍

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 independent-projects/resteasy-reactive/server/vertx

org.jboss.resteasy.reactive.server.vertx.test.sse.SseServerTestCase.shouldNotTryToSendToClosedSink - History

  • 1 expectation failed. Response body doesn't match expectation. Expected: "true" Actual: false - java.lang.AssertionError
java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.
Expected: "true"
  Actual: false

	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)

@geoand
Copy link
Contributor Author

geoand commented Jul 11, 2024

The kubernetes test failure is completely unrelated

@geoand geoand merged commit 929c697 into quarkusio:main Jul 11, 2024
45 of 46 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jul 11, 2024
@geoand geoand deleted the #41811 branch July 11, 2024 12:35
@gsmet gsmet modified the milestones: 3.13 - main, 3.12.3 Jul 16, 2024
@gsmet gsmet modified the milestones: 3.12.3, 3.8.6 Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resteasy Reactive AsyncFile is never closed
3 participants