-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for vertx and qute integration #41558
Conversation
9e0d094
to
4240362
Compare
🎊 PR Preview 322d112 has been successfully built and deployed to https://quarkus-pr-main-41558-preview.surge.sh/version/main/guides/
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this addition. I added a few minor comments.
But that being said, I'm a bit puzzled. Why would you have io.vertx.core.json.JsonObject
in your classpath, if you don't have the quarkus-vertx
extension?
At least in the Quarkus world, that seems like looking for weird issues as Vert.x won't work very well if you don't use the extension.
Could you explain how you stumbled upon this issue and why you wanted to document it?
</dependency> | ||
---- | ||
|
||
With `io.quarkus.vertx` capability we have a special value resolver for `io.vertx.core.json.JsonObject` which makes it possible to access the properties of a JSON object in a template: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With
io.quarkus.vertx
capability
I think this part is a bit too technical. The fact that we use capabilities is internal.
Maybe With this dependency included, ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, With this dependency included,
is better but the "capability" here does not necessarily mean io.quarkus.deployment.Capability
... I mean, it's ok to use this word with its original meaning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're twisting what I'm saying :).
Using the word capability
is fine. But here we are talking about io.quarkus.vertx capability
which is the name of the capability (in the Quarkus meaning of it) thus too technical for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I thought there's quarkus-vertx
... ok then and sorry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, talking about capabilities makes sense when in the context of extension development. So if you're targeting this (and given what you said in another comment, it might be the case), then it makes sense to talk about capabilities.
But again, probably missing some context about when you actually need this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And only keep this one (plus the example bellow) with the new wording suggested by Guillaume.
[source,xml] | ||
---- | ||
<dependency> | ||
<groupId>io.quarkus</groupId> | ||
<artifactId>quarkus-vertx</artifactId> | ||
</dependency> | ||
---- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we should use the tabs with Gradle option too. There are numerous examples in the doc (for instance in validation.adoc
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And the same applies here - remove the GAV.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And the same applies here - remove the GAV.
Why remove GAV @mkouba ?
@gsmet It's a feature requested from https://github.com/quarkiverse/quarkus-roq. The idea is to add the Qute value resolver only if See #41390 for more information. |
@mkouba well, it's your component so your decision but by reading this paragraph, I'm under the impression that, as a Quarkus user, I have to do something on my side when I want to have support for I think this is a bit confusing and adding complexity for something that is an advanced usage and a corner case. It's probably worth documenting it but I would clearly explain the context and when this is actually needed. Because the fact that you needed to actually explain it to me is a sign that it's easy to miss. And I'm not exactly your typical Quarkus user :). Feel free to dismiss my review once the |
This comment has been minimized.
This comment has been minimized.
Thank you for all comments and considerations! |
This comment has been minimized.
This comment has been minimized.
608a5aa
to
7b28b60
Compare
7b28b60
to
12eecc5
Compare
Hi @gsmet, could you make a new review? |
This comment has been minimized.
This comment has been minimized.
🙈 The PR is closed and the preview is expired. |
12eecc5
to
f6e40ea
Compare
This comment has been minimized.
This comment has been minimized.
f6e40ea
to
658f3ae
Compare
This comment has been minimized.
This comment has been minimized.
658f3ae
to
f1046ce
Compare
Hi @gsmet, could you take a new review? |
This comment has been minimized.
This comment has been minimized.
f1046ce
to
8aeaed6
Compare
Status for workflow
|
Fixes #41559