Make 404 page work on Undertow #41448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/core
area/resteasy-classic
area/rest
area/undertow
area/vertx
labels
melloware
approved these changes
Jun 26, 2024
This comment has been minimized.
This comment has been minimized.
phillip-kruger
force-pushed
the
undertow-404
branch
from
d5bab6c
to
bf015e7
Compare
Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>
phillip-kruger
force-pushed
the
undertow-404
branch
from
bf015e7
to
2e37b5f
Compare
Status for workflow
|
|
@cescoffier - CI is green, please have a look. This is the one we discussed. |
cescoffier
approved these changes
Jun 27, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #41372
This was a bit more tricky than anticipated. Initially I just wanted to do event.next when the route is not found so that the request falls down to the Vertx.http handling of 404, However, after trying and talking to Stuart, I realized this is not really possible, as once the request is handed to undertow, there is no way to know if the route is found, except at looking at the response, that is now written so no way to do event.next.
So to allow for this, all the 404 data that is setup during build is moved to an CDI bean that can now be used in the Vertx handler (default case) but also now in a servlet that write 404 responses for Undertow.
Because of this change I could also change the Dev UI to use the preferred Json-RPC way of getting the info, vs as before we just did a fetch on a non-exciting url to get the 404 data.