Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new WithTestResource annotation and deprecate QuarkusTestResource #41368

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Add new WithTestResource annotation and deprecate QuarkusTestResource #41368

merged 1 commit into from
Jun 26, 2024

Conversation

edeandrea
Copy link
Contributor

@edeandrea edeandrea commented Jun 22, 2024 •
edited by geoand
Loading

New annotation replacing @QuarkusTestResource which sets restrictAnnotatedClass=true by default. Also deprecates existing @QuarkusTestResource annotation.

I refactored all of the tests in Quarkus to use the new annotation and made it so restrictAnnotatedClass for every test formerly using @QuarkusTestResource was unchanged. I also added some new tests to be sure both @QuarkusTestResource and @WithTestResource annotations work correctly.

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 22, 2024

/cc @gsmet (hibernate-orm,hibernate-search), @marko-bekhta (hibernate-search), @yrodiere (hibernate-orm,hibernate-search)

@edeandrea
Copy link
Contributor Author

/cc @geoand

@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Jun 26, 2024
@tatu-at-datastax tatu-at-datastax mentioned this pull request Jul 8, 2024
Closed
@gsmet gsmet changed the title Add new WithTestResource annotation Add new WithTestResource annotation and deprecate QuarkusTestResource Jul 18, 2024
@jedla97 jedla97 mentioned this pull request Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/agroal area/cache area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/docstyle issues related for manual docstyle review area/documentation area/flyway area/gradle Gradle area/hibernate-orm Hibernate ORM area/hibernate-search Hibernate Search / Elasticsearch area/hibernate-validator Hibernate Validator area/infinispan Infinispan area/kafka area/kafka-streams area/keycloak area/kubernetes area/liquibase area/mailer area/mongodb area/oidc area/panache area/persistence OBSOLETE, DO NOT USE area/picocli area/redis area/scheduler area/security area/spring Issues relating to the Spring integration area/testing kind/enhancement New feature or request release/noteworthy-feature
Projects
Quarkus Documentation
Status: Done
Milestone
3.13.0.CR1
Development

Successfully merging this pull request may close these issues.

Introduce @WithTestResource as an analogous to @QuarkusTestResource(restrictAnnotatedClass=true)
2 participants
@edeandrea @geoand